Re: [PATCH 1/9] Report bugs consistently

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 2, 2016, 07:25 UTC
Message-ID: <alpine.DEB.2.20.1607020924410.12947@virtualbox>
In-Reply-To: <CACsJy8A1ZU8VgBYmQAVC6LmXMVgt5CgvC_w0Y7Y6oX88RFO3dw@mail.gmail.com>

Hi Duy,

On Sat, 2 Jul 2016, Duy Nguyen wrote:

Show 15 quoted lines

> On Wed, Jun 29, 2016 at 1:36 PM, Johannes Schindelin
> <johannes.schindelin@gmx.de> wrote:
> > @@ -955,9 +955,8 @@ static struct merge_file_info merge_file_1(struct merge_options *o,
> >
> >                         if (!sha_eq(a->sha1, b->sha1))
> >                                 result.clean = 0;
> > -               } else {
> > -                       die(_("unsupported object type in the tree"));
> > -               }
> > +               } else
> > +                       die(_("BUG: unsupported object type in the tree"));
> 
> As a message targeting developers, we do not need to mark this for
> translation. There are a couple other _() in this patch that should be
> removed as well.

Yes, Hannes already pointed that out.

My answer is the same: it is not the purpose of this patch series to fix this, and therefore it retains the previous behavior.

Ciao, Dscho