Re: [PATCH 1/9] Report bugs consistently
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 30, 2016, 08:45 UTC
- Message-ID
- <alpine.DEB.2.20.1606301043320.12947@virtualbox>
- In-Reply-To
- <5774B039.8080802@kdbg.org>
Hi Hannes,
On Thu, 30 Jun 2016, Johannes Sixt wrote:
Show 15 quoted lines
> Am 29.06.2016 um 13:36 schrieb Johannes Schindelin:
> > @@ -955,9 +955,8 @@ static struct merge_file_info merge_file_1(struct
> > merge_options *o,
> >
> > if (!sha_eq(a->sha1, b->sha1))
> > result.clean = 0;
> > - } else {
> > - die(_("unsupported object type in the tree"));
> > - }
> > + } else
> > + die(_("BUG: unsupported object type in the tree"));
>
> Would it perhaps make sense to remove the _() markup (here and a few more
> instances in this patch)? It's simpler for developers to find the code
> location when a "BUG:" is reported untranslated.I would agree, but the purpose of this patch was not to fix that, but to fix the inconsistency of the message.
Maybe as an add-on patch, with *all* 'die(_("BUG:' instances converted? That would be even more outside the purview of my patch series than touching the bug reports outside merge-recursive.c, though.
Ciao, Dscho