Re: [PATCH 1/5] add an extra level of indirection to main()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 1, 2016, 08:04 UTC
Message-ID: <alpine.DEB.2.20.1607010953440.12947@virtualbox>
In-Reply-To: <20160701055858.GA4593@sigill.intra.peff.net>

Hi Peff,

On Fri, 1 Jul 2016, Jeff King wrote:

> I waffled between the two mechanisms. Opinions welcome.

I am happy you took the cmd_main() approach: we do have to play some tricks on Windows, in particular in some upcoming changes that support building with MS Visual C++ (we want to ensure that `argv` is in UTF-8, which means that we actually have to use the UTF-16 versions and convert them manually lest argv has the current Windows encoding of strings). Which means that we still have to use that mingw_startup() trick you mentioned, and which would have interfered had you chosen a similar method.

Show 13 quoted lines

> diff --git a/common-main.c b/common-main.c
> new file mode 100644
> index 0000000..2b96bbf
> --- /dev/null
> +++ b/common-main.c
> @@ -0,0 +1,12 @@
> +#include "git-compat-util.h"
> +
> +int main(int argc, char **av)
> +{
> +	/*
> +	 * This const trickery is explained in
> +	 * 84d32bf7678259c08406571cd6ce4b7a6724dcba

This commit message says that mingw_main() is declared with char **argv, and that is the reason why we have to convert. Maybe spell that out here, and then in a subsequent commit, we can fix the mingw_main() declaration?

Show 5 quoted lines

> +	 */
> +	const char **argv = (const char **)av;
> +
> +	return cmd_main(argc, argv);
> +}

Ciao, Dscho