Re: git-credentials-store.exe crash

From: Jeff King <peff@peff.net>
Date: Jul 1, 2016, 04:07 UTC
Message-ID: <20160701040715.GB4832@sigill.intra.peff.net>
In-Reply-To: <7210bce6-093b-9fdf-9a9b-94059ad0d4e3@ucar.edu>

On Thu, Jun 30, 2016 at 03:24:41PM -0600, dmh@ucar.edu wrote:

Show 13 quoted lines

> Carson:part2: git push
> This application has requested the Runtime to terminate it in an unusual
> way.
> Please contact the application's support team for more information.
> A s s e r t i o n   f a i l e d !
> 
>  P r o g r a m :   C : \ t o o l s \ G i t \ m i n g w 3 2 \ l i b e x e c \
> g i
>  t - c o r e \ g i t - c r e d e n t i a l - s t o r e . e x e
>  F i l e :   e x e c _ c m d . c ,   L i n e   2 3
> 
>  E x p r e s s i o n :   a r g v 0 _ p a t h
>  Everything up-to-date

Interesting. It's failing on the assert(argv0_path) in system_path().

That's part of the RUNTIME_PREFIX code which is built only on Windows, so this is a Windows-specific issue.

I can guess the reason that argv0_path is not set is that credential-store has its own main() function and does not call git_extract_argv0_path(). It never mattered before, but as of v2.8.0, one of the library functions it calls wants to use system_path(), which assumes that the argv0 stuff has been set up.

I'm preparing some patches to fix this case (and some other related ones).

-Peff