git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-credentials-store.exe crash

From
Jeff King <peff@peff.net>
Date
Jul 1, 2016, 07:43 UTC
Message-ID
<20160701074354.GA12006@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.20.1607010938140.12947@virtualbox>
On Fri, Jul 01, 2016 at 09:38:33AM +0200, Johannes Schindelin wrote:
Show 14 quoted lines
> it is sad when bug reporters simply delete the part of our bug reporting
> template that says: "I searched for existing bug reports but did not find
> any".
> 
> It saves the reporters a few minutes... and spends the time of you and me
> in the hour range.
> 
> In this particular case, the bug report is an obvious duplicate of
> https://github.com/git-for-windows/git/issues/766
> 
> The saddest part is that I already spent time to investigate this and to
> come up with a work-around, and I already committed and pushed it.
> 
> So those hours are now thoroughly wasted.

Yeah, you're right. Same bug, and your patch obviously is the right thing to do as an immediate fix.

If it's any consolation, I diagnosed the bug quite quickly, and the extra hours went to solving the greater problem that you mentioned in https://github.com/git-for-windows/git/issues/766#issuecomment-226985175.

So hopefully there is still some value in my series.
-Peff
Previous: Johannes Schindelin
Message 21 of 21 in “git-credentials-store.exe crash”
  1. dmh@ucar.eduJun 30, 2016
  2. Jeff KingJul 1, 2016
  3. 0/5 consistent setup code for external commandsJeff King, Jul 1, 2016
  4. 1/5 add an extra level of indirection to main()Jeff King, Jul 1, 2016
  5. Johannes SchindelinJul 1, 2016
  6. Jeff KingJul 1, 2016
  7. Johannes SchindelinJul 1, 2016
  8. Jeff KingJul 1, 2016
  9. Johannes SchindelinJul 2, 2016
  10. 2/5 common-main: call git_extract_argv0_path()Jeff King, Jul 1, 2016
  11. Johannes SchindelinJul 1, 2016
  12. 3/5 common-main: call sanitize_stdfds()Jeff King, Jul 1, 2016
  13. 5/5 common-main: call git_setup_gettext()Jeff King, Jul 1, 2016
  14. 4/5 common-main: call restore_sigpipe_to_default()Jeff King, Jul 1, 2016
  15. Johannes SchindelinJul 1, 2016
  16. Junio C HamanoJul 1, 2016
  17. Jeff KingJul 1, 2016
  18. Junio C HamanoJul 6, 2016
  19. Johannes SchindelinJul 6, 2016
  20. Johannes SchindelinJul 1, 2016
  21. Jeff KingJul 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.