Re: [PATCH 0/5] consistent setup code for external commands

From: Jeff King <peff@peff.net>
Date: Jul 1, 2016, 22:39 UTC
Message-ID: <20160701223912.GB32545@sigill.intra.peff.net>
In-Reply-To: <xmqq4m89vw5i.fsf@gitster.mtv.corp.google.com>

On Fri, Jul 01, 2016 at 03:19:37PM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> > Here they are:
> >
> >   [1/5]: add an extra level of indirection to main()
> >   [2/5]: common-main: call git_extract_argv0_path()
> >   [3/5]: common-main: call sanitize_stdfds()
> >   [4/5]: common-main: call restore_sigpipe_to_default()
> >   [5/5]: common-main: call git_setup_gettext()
> 
> As this is also a fix to maint-2.8 track, I tweaked them to ensure
> that they apply there, and queued the result as jk/common-main.  I
> double checked the result by comparing the result of applying these
> five patches directly on top of master, and the result of merging
> that jk/common-main (based on maint-2.8) into master, and they seem
> to match.

Thanks, this obviously is a regression in v2.8, but I didn't even think about that and just built it on top of master.

I think the cleanup that Dscho suggested elsewhere in the thread is a good idea on top, but that can also just wait and come separately.

-Peff