Re: [PATCH 0/5] consistent setup code for external commands
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 1, 2016, 07:45 UTC
- Message-ID
- <alpine.DEB.2.20.1607010939350.12947@virtualbox>
- In-Reply-To
- <20160701055532.GA4488@sigill.intra.peff.net>
Hi Peff,
On Fri, 1 Jul 2016, Jeff King wrote:
> - for external programs run as "git foo", you get _two_ times.
I considered doing this in my work-around, but decided against it because I deemed it too inelegant to call it twice.
But your patch series has more benefits than just fixing the assertion in the credential-store.
For one, it makes test programs such as test-dump-untracked-cache.exe usable outside Git's test suite without any major envvar jujitsu.
So once the dust settles, I will revert my commit in git-for-windows.git and merge in your patches.
Thanks, Dscho