git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] add an extra level of indirection to main()

From
Jeff King <peff@peff.net>
Date
Jul 1, 2016, 22:38 UTC
Message-ID
<20160701223809.GA32545@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.2.20.1607011449380.12947@virtualbox>
On Fri, Jul 01, 2016 at 03:39:03PM +0200, Johannes Schindelin wrote:
Show 10 quoted lines
> > The description was sufficiently long that I didn't want to try
> > repeating it, and opted for a reference instead. If you're planning to
> > fix mingw_main(), I'd be happy to do that as a preparatory patch, and
> > then just skip this trickery entirely. :)
> 
> Deal:
> 
> ½/5 is in 5c54dff5c54e68a1101d8fe37aefc6158fddd7f2 and the fixup for 1/5
> is in 7b74f7aabb56b428c74f5983c066dc9ea8fe5116 in the 'common-main' branch
> on https://github.com/dscho/git.

Hrm. I didn't find 5c54dff5c when I fetched from dscho/git. However, having seen 7b74f7aa, the one that comes on top, I actually think that's what we really want anyway. It's really my first patch that makes your cleanup safe to do.

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 21 in “git-credentials-store.exe crash”
  1. dmh@ucar.eduJun 30, 2016
  2. Jeff KingJul 1, 2016
  3. 0/5 consistent setup code for external commandsJeff King, Jul 1, 2016
  4. 1/5 add an extra level of indirection to main()Jeff King, Jul 1, 2016
  5. Johannes SchindelinJul 1, 2016
  6. Jeff KingJul 1, 2016
  7. Johannes SchindelinJul 1, 2016
  8. Jeff KingJul 1, 2016
  9. Johannes SchindelinJul 2, 2016
  10. 2/5 common-main: call git_extract_argv0_path()Jeff King, Jul 1, 2016
  11. Johannes SchindelinJul 1, 2016
  12. 3/5 common-main: call sanitize_stdfds()Jeff King, Jul 1, 2016
  13. 5/5 common-main: call git_setup_gettext()Jeff King, Jul 1, 2016
  14. 4/5 common-main: call restore_sigpipe_to_default()Jeff King, Jul 1, 2016
  15. Johannes SchindelinJul 1, 2016
  16. Junio C HamanoJul 1, 2016
  17. Jeff KingJul 1, 2016
  18. Junio C HamanoJul 6, 2016
  19. Johannes SchindelinJul 6, 2016
  20. Johannes SchindelinJul 1, 2016
  21. Jeff KingJul 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.