Re: [PATCH v2] git config: report when trying to modify a non-existing repo config

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 24, 2016, 13:26 UTC
Message-ID: <alpine.DEB.2.20.1602241425180.3152@virtualbox>
In-Reply-To: <20160224125930.GA1422@lanh>

Hi Duy,

On Wed, 24 Feb 2016, Duy Nguyen wrote:

Show 5 quoted lines

> On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote:
> > +		die("not in a git directory");
> 
> Maybe wrap this string with _() for translation? Then we can pile this
> patch on top to fix the rest in builtin/config.c.

Given that the context lines contain die() calls *without* _(), I would find it more logical if your patch patched also the line I introduced, together with the other die() calls.

Ciao, Dscho