Re: [PATCH] git config: do not create .git/ if it does not exist yet

From: Jeff King <peff@peff.net>
Date: Feb 24, 2016, 12:34 UTC
Message-ID: <20160224123444.GA27909@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1602241309560.3152@virtualbox>

On Wed, Feb 24, 2016 at 01:13:39PM +0100, Johannes Schindelin wrote:

Show 11 quoted lines

> > I created a test and essentially duplicated Peff's finding: this is a
> > Windows-only issue.
> 
> Indeed it is in our patches:
> 
> 	https://github.com/git-for-windows/git/commit/3a4c37b22
> 
> (short version: we carry some patches that simplify locking the config
> file before building on top of it, and somehow we agreed back in the days
> when this patch was written that it would be a good idea if that code
> created leading directories.)

Thanks for tracking it down.

> I will fix this issue in Git for Windows, but I still think that my patch
> brings a usability improvement: the error message is just so much more to
> the point (will submit v2 in a moment).

Yeah, I agree it is still worth doing.

-Peff