From: Johannes Schindelin Date: Wed, 24 Feb 2016 13:26:06 GMT Subject: Re: [PATCH v2] git config: report when trying to modify a non-existing repo config Message-ID: In-Reply-To: <20160224125930.GA1422@lanh> Hi Duy, On Wed, 24 Feb 2016, Duy Nguyen wrote: > On Wed, Feb 24, 2016 at 01:48:11PM +0100, Johannes Schindelin wrote: > > + die("not in a git directory"); > > Maybe wrap this string with _() for translation? Then we can pile this > patch on top to fix the rest in builtin/config.c. Given that the context lines contain die() calls *without* _(), I would find it more logical if your patch patched also the line I introduced, together with the other die() calls. Ciao, Dscho