Re: [PATCH] git config: do not create .git/ if it does not exist yet

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 24, 2016, 11:31 UTC
Message-ID: <alpine.DEB.2.20.1602241230120.3152@virtualbox>
In-Reply-To: <20160224103152.GA21448@sigill.intra.peff.net>

Hi Peff, John & Junio (who recommended GIT_CEILING_DIRECTORIES first,

On Wed, 24 Feb 2016, Jeff King wrote:

Show 13 quoted lines

> On Wed, Feb 24, 2016 at 10:14:03AM +0000, John Keeping wrote:
> 
> > On Wed, Feb 24, 2016 at 03:26:57AM -0500, Jeff King wrote:
> > > On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote:
> > > 
> > > > 	I cannot think of a way how to test this: all of the regression
> > > > 	tests run inside Git's own worktree, and we cannot even assume
> > > > 	that /tmp/ is outside of a worktree (or that it exists).
> > > 
> > > We could make the test conditional on whether we are in a repo. Anybody
> > > who builds from a tarball, or who uses --root would then run the test.
> > 
> > Could we use GIT_CEILING_DIRECTORIES for this?

Absolutely. I created a test and essentially duplicated Peff's finding: this is a Windows-only issue.

Will keep you posted, Dscho