Re: [PATCH] git config: do not create .git/ if it does not exist yet

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2016, 18:45 UTC
Message-ID: <xmqqio1et0a3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1602241309560.3152@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 15 quoted lines

> Hi,
>
> On Wed, 24 Feb 2016, Johannes Schindelin wrote:
>
>> I created a test and essentially duplicated Peff's finding: this is a
>> Windows-only issue.
>
> Indeed it is in our patches:
>
> 	https://github.com/git-for-windows/git/commit/3a4c37b22
>
> (short version: we carry some patches that simplify locking the config
> file before building on top of it, and somehow we agreed back in the days
> when this patch was written that it would be a good idea if that code
> created leading directories.)

The log message there says this:

    This is particularly important when calling

         git config -f /non/existing/directory/config ...

I think that the change should be ejected.

	cat >/non/existing/directory/file
	mkdir /non/existing/directory/dir

would fail, and I do not see any valid reason for "git config" to be different.

> I will fix this issue in Git for Windows, but I still think that my patch
> brings a usability improvement: the error message is just so much more to
> the point (will submit v2 in a moment).

Thanks.  I think your patch in this thread is an improvement.