Re: [PATCH] git config: do not create .git/ if it does not exist yet

From: John Keeping <john@keeping.me.uk>
Date: Feb 24, 2016, 10:14 UTC
Message-ID: <20160224101403.GN1766@serenity.lan>
In-Reply-To: <20160224082657.GD12511@sigill.intra.peff.net>

On Wed, Feb 24, 2016 at 03:26:57AM -0500, Jeff King wrote:

Show 8 quoted lines

> On Wed, Feb 24, 2016 at 08:47:00AM +0100, Johannes Schindelin wrote:
> 
> > 	I cannot think of a way how to test this: all of the regression
> > 	tests run inside Git's own worktree, and we cannot even assume
> > 	that /tmp/ is outside of a worktree (or that it exists).
> 
> We could make the test conditional on whether we are in a repo. Anybody
> who builds from a tarball, or who uses --root would then run the test.

Could we use GIT_CEILING_DIRECTORIES for this? If it's set to TEST_OUTPUT_DIRECTORY won't that cover the in-tree and out-of-tree test cases?

We probably do still want Peff's REPOLESS prereq just in case someone is collecting test results in a repository, but I think that will see much better coverage than relying on people running tests from the tarball.