Re: [PATCH v2] Add a Windows-specific fallback to getenv("HOME");
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 5, 2014, 13:39 UTC
- Message-ID
- <alpine.DEB.1.00.1406051411580.14982@s15462909.onlinehome-server.info>
- In-Reply-To
- <53903B22.70507@gmail.com>
Hi Karsten,
On Thu, 5 Jun 2014, Karsten Blees wrote:
Show 8 quoted lines
> Am 05.06.2014 10:03, schrieb Stepan Kasal:
>
> * even if $HOME was empty, git should setenv("HOME") so that child
> processes can benefit from it (similar to TMPDIR and TERM in current
> msysgit's mingw_startup()). Not setting $HOME because it may
> hypothetically break child processes is a very weak argument, as we
> always did set $HOME in etc/profile (since the initial version back in
> 2007).I do remember that I tried that first, as I mentioned in this thread. There must have been a breakage preventing me from going that route.
And in particular with your changes to Unicodify the complete environment, I am *highly* doubtful that child processes will be able to handle themselves properly, unless we spend a whole lot of time converting back and forth the environment when calling children.
Ciao, Dscho
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.