Re: [PATCH v2] Add a Windows-specific fallback to getenv("HOME");
- From
Stepan Kasal <kasal@ucw.cz>
- Date
- Jun 5, 2014, 11:23 UTC
- Message-ID
- <20140605112322.GB28309@camelia.ucw.cz>
- In-Reply-To
- <53903B22.70507@gmail.com>
Hello,
On Thu, Jun 05, 2014 at 11:40:50AM +0200, Karsten Blees wrote:
Show 6 quoted lines
> Am 05.06.2014 10:03, schrieb Stepan Kasal: > > I hope you can ack this patch as a step forward. > > No, not really. It's sure better than introducing a special > get_home_directory(), but it still increases the diff between > upstream and msysgit rather than reducing it. [...]
this patch (v3) is a win-win for both sides:
- upstream would get at least $HOMEDRIVE$HOMEPATH - downstream would get rid of get_home_directory - it would decrease the diff, in my metric[*]
[*] The patch with get_home_directory() could be that dropped. Yes, the patch "84b7969 Win32: patch Windows environment on startup" would have to be updated, but I can handle that easily.
> The main critique points still remain:
> * $HOME is usually set up correctly before calling git, [...]
> * even if $HOME was empty, git should setenv("HOME") [...]
> * no fallback to $USERPROFILE [...]This is a plan for further work, but not an argument against the current version of patch.
> If you really have time to spare, I suggest you focus on getting > the Unicode patches upstream so that we can progress from there
Not that much time. That's why I try to push the patches that seem to be simpler. Some get discussed, some get ignored, but some get accepted (or dropped).
Stepan
PS: tongue in cheek: If _you_ could find some time, could you please support these: http://thread.gmane.org/gmane.comp.version-control.msysgit/20324
The first patch of the pair introduces mingw_startup, which is a good base for other changes. The second one is my new fix for const warnings, exactly according to the lines mentioned here: instead of fixing all the consumers and waiting when it'll break again, I modified the mingw-specific code to adapt better.
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.