Re: Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");
- From
Stepan Kasal <kasal@ucw.cz>
- Date
- Jun 4, 2014, 15:45 UTC
- Message-ID
- <20140604154503.GB22681@camelia.ucw.cz>
- In-Reply-To
- <alpine.DEB.1.00.1406041725460.14982@s15462909.onlinehome-server.info>
Hi dscho,
> > On Wed, Jun 4, 2014 at 5:14 PM, Johannes Schindelin > > <Johannes.Schindelin@gmx.de> wrote: > > > No. Git is not always called through Bash or the git-wrapper, > > > unfortunately.
but you have to admit, that in most cases it is called through bash or the git wrapper.
> The problem arises whenever git.exe calls subprocesses. You can pollute > the environment by setting HOME, I do not recall the details, but I > remember that we had to be very careful *not* to do that, hence the patch. > Sorry, has been a long time.
Yeah, memories. Is this experience still valid? How many users do profit from this, using c:/Program\ Files \(86\)/bin/git.exe instead of c:/Program\ Files \(86\)/cmd/git.exe, either by pure luck or intentionally?
It seems that we should keep the patch, to minimize surprise if bin/git.exe is used directly.
But we should probably make it consistent with other places: - $HOMEDRIVE$HOMEPATH (without the slash) - $USERPROFILE if the above dir does not exist. - setenv HOME instead of wrapper
We can make this change for msysGit 2.0.0 only, so that we do not break 1.9.4 ;-)
Does this make sense? Stepan
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.