Re: [PATCH v2] Add a Windows-specific fallback to getenv("HOME");
Am 05.06.2014 11:58, schrieb Erik Faye-Lund:
Show 23 quoted lines
> On Thu, Jun 5, 2014 at 11:40 AM, Karsten Blees <karsten.blees@gmail.com> wrote:
>> Am 05.06.2014 10:03, schrieb Stepan Kasal:
>>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>> Date: Wed, 2 Jun 2010 00:41:33 +0200
>>>
>>> If HOME is not set, use $HOMEDRIVE$HOMEPATH
>>>
>>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>>> Signed-off-by: Stepan Kasal <kasal@ucw.cz>
>>> ---
>>>
>>> Hello Karsten,
>>> thanks for your explanation. There are more things to be done, but
>>> I hope you can ack this patch as a step forward.
>>>
>>
>> No, not really. Its sure better than introducing a special get_home_directory(), but it still increases the diff between upstream and msysgit rather than reducing it. The main critique points still remain:
>>
>> * $HOME is usually set up correctly before calling git, so this is essentially dead code (just checked, portable git's git-bash.bat and git-cmd.bat also do this correctly)
>
> What about when tools like TortoiseGit and Git Extensions call git?
> We're not guaranteed that they did the $HOME-dance, are we?
>
GitExtensions does the same thing, see issue 497. I don't know about TortoiseGit, but I suspect the same.
Show 10 quoted lines
>> * even if $HOME was empty, git should setenv("HOME") so that child processes can benefit from it (similar to TMPDIR and TERM in current msysgit's mingw_startup()). Not setting $HOME because it may hypothetically break child processes is a very weak argument, as we always did set $HOME in etc/profile (since the initial version back in 2007).
>>
>> * no fallback to $USERPROFILE doesn't work with diconnected home share
>>
>> If you really have time to spare, I suggest you focus on getting the Unicode patches upstream so that we can progress from there (e.g. move $HOME setup to mingw_startup() so that we can get rid of redundant logic in etc/profile, git-wrapper, git-bash.bat, git-cmd.bat etc.).
>
> Perhaps we can patch up the upstream to better match Git for Windows
> without upstreaming the Unicode patches? Don't get me wrong; I think
> upstreaming them is a good idea, but in case time is lacking...
> The unicode patch series happens to be one of the first on top of upstream, and its also the longest (~40 patches) and I believe most intrusive one (~1500 lines changed). So I think the most time-preserving option is to send it upstream as unchanged as possible (probably with the bugfix-patches squashed). There's only ~50 lines changed outside of compat, so hopefully there won't be too many additional review-rounds...
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Karsten Blees <karsten.blees@gmail.com>