Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");

From: Stepan Kasal <kasal@ucw.cz>
Date: Jun 4, 2014, 14:53 UTC
Message-ID: <20140604145350.GA22681@camelia.ucw.cz>
In-Reply-To: <CACsJy8BDk4gdRzjp_XpQXXMW1sEnS4DoedanFLONODuJXdeeRA@mail.gmail.com>

Hello,

On Wed, Jun 04, 2014 at 08:47:58PM +0700, Duy Nguyen wrote:

> setenv("HOME") if it's missing instead? MinGW port already replaces
> main(). Extra initialization should not be a problem.

well, I would be afraid to modify the environment for subprocesses. It could hit back in certain situations, like with git filter-branch.

We could replace getenv() with a wrapper though. But I don't think it's worth it.

> I feel
> "getenv("HOME")" a tiny bit more familiar than get_home_directory(),
> but that's really weak argument as the number of call sites has not
> increased in 4 years.

Actually, the patch had to be updated when msysgit modifications were rebased. But yes, the number of call sites has not icreased: it was called in four places back than, and it is called at three places now. There is only one that is in common, though.

Stepan

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.