Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 2, 2010, 23:00 UTC
Message-ID: <alpine.DEB.1.00.1002022356460.4985@pacific.mpi-cbg.de>
In-Reply-To: <76c5b8581002021431o2b5073a0s42b273b6d61893db@mail.gmail.com>

Hi,

On Tue, 2 Feb 2010, Eugene Sajine wrote:

[somebody wrote this, I suspect it was Wincent]

Show 8 quoted lines

>
> > Why should Git care about how you exited from your EDITOR? All it 
> > should care about is the contents of the commit message, and the exit 
> > code of the editor.
> 
> It doesn't matter which editor is used. The only thing that matters is 
> that you saving or not saving on exit from editor. If not saving - abort 
> the action.

No. If not saving, then it means that the user was fine with the message as-is.

Remember, --amend is usually for amending the _content_ of the patch, not so much the message.

Of course, you could come up with wonderfully complicated strategies such as "if nothing was added, then an unmodified commit message means 'abort', else it means 'go ahead'", but I hope that you agree that this would be very bad from the users' POV: it would be utterly confusing.

Ciao, Dscho