Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

From: Eugene Sajine <euguess@gmail.com>
Date: Feb 2, 2010, 23:34 UTC
Message-ID: <76c5b8581002021534i1f0dbd18y1b216233d282cd84@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.1002022356460.4985@pacific.mpi-cbg.de>

> Of course, you could come up with wonderfully complicated strategies such
> as "if nothing was added, then an unmodified commit message means 'abort',
> else it means 'go ahead'", but I hope that you agree that this would be
> very bad from the users' POV: it would be utterly confusing.

No complicated strategies necessary. I'm not talking about modified or not modified commit message. I'm not forcing anybody to modify commit message in order to proceed with commit --amend. I'm talking about consistent behaviour of main operations:

Commit - you must save on exit from your editor, simply exiting will abort.

Same should be applied to rebase -i and of course to commit --amend as it is still commit operation.

Even if the text is OK or you agree with generated sequence of rebase
- confirm that explicitly by saving on exit from the editor, else it
should abort. Pretty obvious to me...;)

Thanks, 'Eugene