Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 3, 2010, 17:51 UTC
Message-ID: <20100203175118.GA2982@progeny.tock>
In-Reply-To: <76c5b8581002030745g634d6ec1hb9e87b687e58e521@mail.gmail.com>

Eugene Sajine wrote:

> On Wed, Feb 3, 2010 at 2:31 AM, Matthieu Moy

Show 10 quoted lines

>> Just try:
>>
>> Create a file.
>> 1) Launch emacs, save and quit.
>> 2) Launch emacs, don't save, and quit.
>>
>> From outside, it's EXACTLY the same thing. In the first case, emacs
>> will just tell you "no change need to be saved" and quit, in the
>> second, it'll quit. Try deleting the file in the meantime, it won't
>> change the behavior.

Show 6 quoted lines

> Please, do not assume i don't understand that file opened in editor
> and saved with no changes will be the same as not saved.
> 
> Please, do not assume i don't understand that current implementation
> does not allow to correctly abort by simply quiting the editor,
> because it uses the file content only to verify if it can proceed.

I’ll bite. Please reread Mattheiu’s message. Pay particular attention to the lines

	In the first case, emacs
	will just tell you "no change need to be saved" and quit, in the
	second, it'll quit.

and

	Try deleting the file in the meantime, it won't
	change the behavior.

and consider what this means about what is happening and the resulting stat() information.

It is a bit frustrating to read this thread because Mattheiu was not the first thing to say this (and many have mentioned other problems, too, such as people’s muscle memory), but you do not seem to respond to them. Instead, you keep repeating the same thing...

Hope that helps, Jonathan