Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

From: Eugene Sajine <euguess@gmail.com>
Date: Feb 2, 2010, 23:27 UTC
Message-ID: <76c5b8581002021527s446fda1dh3a5001b9a4996538@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.1002030014100.4985@pacific.mpi-cbg.de>

Show 7 quoted lines

>> Frankly, I think that "rebase -i" is the best example when exiting
>> without save should abort, not proceed.
>
> That would be horrible! If the list of commits I want to apply happens to
> be exactly what I want without needing any reordering/removing, then it
> would abort, according to you.
>

No! It wouldn't if you save instead of simply exiting, if you type :wq instead :q

I'm obviously failing to express my self ...;)

NOTHING is supposed to change for you except that you have to save on exit, write the file, confirm changes or absence of such, agree with generated content of rebase sequence. That is all i'm talking about.

You MUST save the file when you do commit - right? Because this file COMMIT_EDITMSG is empty. It will fail to commit otherwise - right? The problem is that this file is NOT empty when there is a prepopulated message like rebase -i sequence of commits or message from commit being amended. Therefore, you can exit without saving and the action will still happen - which is wrong and not consistent with "commit"!

Exit without saving for me means FORGET what i was doing here . So, it is obvious, that when I'm doing rebase -i and working with the list of commits exit without saving should mean - FORGET about rebase.

Thanks, Eugene