Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Feb 2, 2010, 22:03 UTC
- Message-ID
- <40aa078e1002021403x49920df9x3eca13207ce3e9f9@mail.gmail.com>
- In-Reply-To
- <76c5b8581002021356m52bb1817k9a4a29da0d4b681d@mail.gmail.com>
On Tue, Feb 2, 2010 at 10:56 PM, Eugene Sajine <euguess@gmail.com> wrote:
Show 14 quoted lines
>> >> As has already been pointed out, an extremely common workflow for "git >> commit --amend" is to include additional changes that were accidentally >> overlooked in the initial commit, and no changes are made to the commit >> message. >> >> Changing the behavior would break that perfectly reasonable, >> widely-practised workflow, and _that_ would be 100% not ok. > > I'm not against that workflow - I'm not forcing anybody to change the > commit message. The thing I'm talking about is roughly that it should > NOT treat the result of command ":q" the same way as the command > ":wq". >
Quite a lot of text-editors on prevents a user from saving when the buffer is unchanged, so I don't think this would actually work. Keep in mind that vi is not the only editor one can use to edit commit messages.
-- Erik "kusma" Faye-Lund