Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Feb 2, 2010, 23:40 UTC
Message-ID: <40aa078e1002021540i13e35776xd733a4e40f34b477@mail.gmail.com>
In-Reply-To: <76c5b8581002021534i1f0dbd18y1b216233d282cd84@mail.gmail.com>

On Wed, Feb 3, 2010 at 12:34 AM, Eugene Sajine <euguess@gmail.com> wrote:

Show 13 quoted lines

>> Of course, you could come up with wonderfully complicated strategies such
>> as "if nothing was added, then an unmodified commit message means 'abort',
>> else it means 'go ahead'", but I hope that you agree that this would be
>> very bad from the users' POV: it would be utterly confusing.
>
> No complicated strategies necessary.
> I'm not talking about modified or not modified commit message. I'm not
> forcing anybody to modify commit message in order to proceed with
> commit --amend.
> I'm talking about consistent behaviour of main operations:
>
> Commit - you must save on exit from your editor, simply exiting will abort.
>

This is where you're wrong. The reason why commit (without --amend) is aborting when you don't save is that the default commit message is empty, not that it wasn't saved. In fact, just saving still makes in abort. You need to add something to the commit message and then save to get it to perform the commit.

> Same should be applied to rebase -i and of course to commit --amend as
> it is still commit operation.
>

"rebase -i" and "commit --amend" already has the exact same logic as commit without ammend in this regard - they abort if the buffer is empty.

-- 
Erik "kusma" Faye-Lund