Re: [PATCH] Add the diff option --no-defaults
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 16, 2009, 17:36 UTC
- Message-ID
- <alpine.DEB.1.00.0904161935570.6798@intel-tinevez-2-302>
- In-Reply-To
- <7v4owok0bh.fsf@gitster.siamese.dyndns.org>
Hi,
On Thu, 16 Apr 2009, Junio C Hamano wrote:
Show 20 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Thu, Apr 16, 2009 at 11:25:08AM +0200, Johannes Schindelin wrote: > > > >> > This feels very hack-ish to me, but perhaps this is a case of "perfect > >> > is the enemy of the good". > >> > >> I have a strong feeling that none of our diff/rev options can sanely take > >> a parameter looking like "--defaults" or "--no-defaults". > >> > >> But I do not have the time to audit the options. Maybe you have? > > > > Right now, I think we are safe. A few options like "--default" do take a > > separated string argument, but saying "--default --no-defaults" seems a > > little crazy to me (besides being confusing because they are talking > > about two totally unrelated defaults). > > Maybe you guys have already considered and discarded this as too hacky, > but isn't it the easiest to explain and code to declare --no-defaults is > acceptable only at the beginning?
That would not work if you use an alias:
$ git config alias.grmpfl log --stat $ git grmpfl --no-defaults
Ciao, Dscho