Re: [PATCH v2 1/2] Introduce config variable "diff.primer"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 7, 2009, 21:45 UTC
- Message-ID
- <7vocxdudj0.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20090206161954.GA18956@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> Right, I am calling into question whether we want "--primer" at all. > That is, if you think of it as just "prepend these command line options" > we can get the same thing with something like: > > git diff-tree `git config diff.primer` $other_options > > if the caller wants to be totally promiscuous, and > > git diff-tree `git config diff.primer | filter_options` $other_options > > if it wants to be paranoid (and obviously in tcl the code would be > different, but I think you can see the point).
I agree with this 100%.
Also, I think we should explain the semantics of diff.primer to new people like that. "The diff Porcelain command acts as if whatever you have in diff.primer are prepended on your command line".
Which means that we do not have to touch the plumbing at all. That allows me sleep much better at night.