Re: [PATCH] NO_PERL support
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 3, 2009, 14:51 UTC
- Message-ID
- <alpine.DEB.1.00.0904031649400.10279@pacific.mpi-cbg.de>
- In-Reply-To
- <20090403132029.GC21153@coredump.intra.peff.net>
Hi,
On Fri, 3 Apr 2009, Jeff King wrote:
Show 23 quoted lines
> On Fri, Apr 03, 2009 at 12:03:50AM -0700, Robin H. Johnson wrote: > > > Effects: > > - No perl-based scripts or code are installed: > > $SCRIPT_PERL > > git-instaweb > > gitweb > > git-cvsserver > > git-svn > > - git-add does NOT have interactive support. > > - None of the tests for the disabled stuff gets run. > > Hmm. With this patch, a user with a NO_PERL build will just get: > > $ git svn > git: 'svn' is not a git-command. See 'git --help'. > $ git add -i > error: unknown switch `i' > usage: ... > > I wonder if we should be a little nicer and say "we know about this > command or option, but we did not build support for it". OTOH, what you > have mirrors what NO_TCLTK does, so perhaps it is not a big deal.
Actually, "add -i" is a part of another program that does work without Perl, so it is quite a different kind of kettle.
It is not like "git gui" works with NO_TCLTK but "git gui -i" does not.
Ciao, Dscho