Re: [PATCH 3/4] Makefile: allow building without perl
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- Apr 4, 2009, 23:51 UTC
- Message-ID
- <20090404T234556Z@curie.orbis-terrarum.net>
- In-Reply-To
- <20090404233936.GB26906@coredump.intra.peff.net>
On Sat, Apr 04, 2009 at 07:39:36PM -0400, Jeff King wrote:
Show 5 quoted lines
> > +ifeq ($(wildcard $(PERL_PATH)),) > I'm not sure what you're trying to accomplish with the wildcard, unless > it is "PERL_PATH = /usr/*/perl" or similar, but that seems a bit crazy > to me. It should probably behave the same as TCLTK_PATH, though (so if > there is a good use case, TCLTK_PATH should be enhanced).
No. The ifeq ($(wildcard $(PERL_PATH)),) is entirely correct. It's one of the few ways to detect the existence of a file from within Make, without any exec calls. If you give it a non-expandable path, /usr/bin/perl in this case, it checks only that path, and either returns it or an empty string. This enables us to check that /usr/bin/perl exists, and take suitable action if it does not.
It's not suitable for use with the TCLTK_PATH, as that isn't an absolute path, so the wildcard trick doesn't work.
> I don't think there is a point in setting NO_PERL_MAKEMAKER if NO_PERL > is set, and I believe the export is pointless, as I described in an > earlier email.
From further down the Makefile:
ifdef NO_PERL_MAKEMAKER
export NO_PERL_MAKEMAKER
endif-- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85