Re: [PATCH] NO_PERL support

From: Robin H. Johnson <robbat2@gentoo.org>
Date: Apr 3, 2009, 15:59 UTC
Message-ID: <20090403T155623Z@curie.orbis-terrarum.net>
In-Reply-To: <20090403154608.GA27089@coredump.intra.peff.net>

On Fri, Apr 03, 2009 at 11:46:08AM -0400, Jeff King wrote:

> Also, a few meta-issues with this patch.
>
> One is that the usual practice is to send patches inline rather than
> attaching them.

I usually send as attachments, as the filename of the patch is important as well, and the majority of places that I submit to want attachments.

> Another is that this text:

...

> should go with the patch as part of the commit message along with this:

The text was specifically describing it for the Git community.

...

> If you are using git to prepare your patch, then "git format-patch"
> should generate the right output.

This patch was generated with format-patch years ago, but has been hand-tuned since.

Show 14 quoted lines

> And finally, these two hunks:
> > diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
> > index 6a37f71..84a0d31 100755
> > --- a/t/t9400-git-cvsserver-server.sh
> > +++ b/t/t9400-git-cvsserver-server.sh
> > @@ -17,6 +17,12 @@ then
> > [...]
> > diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> > index 6ed10d0..d4580a4 100755
> > --- a/t/t9500-gitweb-standalone-no-errors.sh
> > +++ b/t/t9500-gitweb-standalone-no-errors.sh
> did not apply for me, to the current 'master' or 'next'. Furthermore,
> the blobs they are based on aren't even present in my repo, so a 3-way
> merge was impossible. What did you base this patch on?

The patch applies cleanly to the 1.6.2.* tarballs.

-- 
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85