Re: [PATCH] NO_PERL support

From: Jeff King <peff@peff.net>
Date: Apr 3, 2009, 14:53 UTC
Message-ID: <20090403145329.GA25967@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0904031649400.10279@pacific.mpi-cbg.de>

On Fri, Apr 03, 2009 at 04:51:09PM +0200, Johannes Schindelin wrote:

Show 16 quoted lines

> > Hmm. With this patch, a user with a NO_PERL build will just get:
> > 
> >   $ git svn
> >   git: 'svn' is not a git-command. See 'git --help'.
> >   $ git add -i
> >   error: unknown switch `i'
> >   usage: ...
> > 
> > I wonder if we should be a little nicer and say "we know about this
> > command or option, but we did not build support for it". OTOH, what you
> > have mirrors what NO_TCLTK does, so perhaps it is not a big deal.
> 
> Actually, "add -i" is a part of another program that does work without 
> Perl, so it is quite a different kind of kettle.
> 
> It is not like "git gui" works with NO_TCLTK but "git gui -i" does not.

Yes, there are really two cases here:

  1. options to programs that will be disabled

  2. whole programs that will not be installed

Are you proposing to print "sorry, perl support not compiled in" (or whatever) for case 1, but ignore case 2? (And I am not sure if that is a bad idea, but I am trying to be clear on what you mean).

-Peff