Re: [PATCH] NO_PERL support
- From
Jeff King <peff@peff.net>
- Date
- Apr 3, 2009, 16:18 UTC
- Message-ID
- <20090403161822.GB8155@coredump.intra.peff.net>
- In-Reply-To
- <20090403T155623Z@curie.orbis-terrarum.net>
On Fri, Apr 03, 2009 at 08:59:38AM -0700, Robin H. Johnson wrote:
Show 7 quoted lines
> I usually send as attachments, as the filename of the patch is important > as well, and the majority of places that I submit to want attachments. > [...] > The text was specifically describing it for the Git community. > [...] > This patch was generated with format-patch years ago, but has been > hand-tuned since.
Ah, OK. Maybe I misunderstood; I thought you were submitting this for inclusion in upstream git. In which case things like the patch filename would become irrelevant (and the maintainer's ability to apply via "git am" would become relevant).
> > did not apply for me, to the current 'master' or 'next'. Furthermore, > > the blobs they are based on aren't even present in my repo, so a 3-way > > merge was impossible. What did you base this patch on? > The patch applies cleanly to the 1.6.2.* tarballs.
OK, thanks.
-Peff