git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] NO_PERL support

From
Jeff King <peff@peff.net>
Date
Apr 3, 2009, 18:37 UTC
Message-ID
<20090403183738.GA15926@coredump.intra.peff.net>
In-Reply-To
<200904031954.57584.j6t@kdbg.org>
On Fri, Apr 03, 2009 at 07:54:57PM +0200, Johannes Sixt wrote:
> If you base the patch on 'master', you can add this line to test-lib.sh
> 
> test -z "$NO_PERL" && test_set_prereq PERL
Thanks, I'm working up a patch using this now.
> [But actually, if I read you patch correctly, NO_PERL will be set in 
> t/Makefile only if one runs 'make test' from the main directory. You should 
> invent some method to detect missing perl (or that NO_PERL was set) if 'make' 
> is run directly from t/.]

Yes, it should go into GIT-BUILD-OPTIONS which gets sourced by test-lib.sh (and then it not only works with "make test" from "t/", but also with "sh t????-whatever.sh".

-Peff
Previous: Johannes SixtNext: Jeff King
Message 9 of 30 in “NO_PERL support”
  1. NO_PERL supportRobin H. Johnson, Apr 3, 2009
  2. Jeff KingApr 3, 2009
  3. Johannes SchindelinApr 3, 2009
  4. Jeff KingApr 3, 2009
  5. Johannes SchindelinApr 3, 2009
  6. Miklos VajnaApr 3, 2009
  7. Jeff KingApr 3, 2009
  8. Johannes SixtApr 3, 2009
  9. Jeff KingApr 3, 2009
  10. Jeff KingApr 3, 2009
  11. Robin H. JohnsonApr 3, 2009
  12. Jeff KingApr 3, 2009
  13. Junio C HamanoApr 3, 2009
  14. Jeff KingApr 3, 2009
  15. Junio C HamanoApr 3, 2009
  16. Jeff KingApr 3, 2009
  17. 0/4 NO_PERL supportJeff King, Apr 3, 2009
  18. 1/4 commit: abort commit if interactive add failedJeff King, Apr 3, 2009
  19. 2/4 tests: remove exit after test_done callJeff King, Apr 3, 2009
  20. 3/4 Makefile: allow building without perlJeff King, Apr 3, 2009
  21. Robin H. JohnsonApr 4, 2009
  22. Jeff KingApr 4, 2009
  23. Robin H. JohnsonApr 4, 2009
  24. Jeff KingApr 4, 2009
  25. Robin H. JohnsonApr 5, 2009
  26. Jeff KingApr 7, 2009
  27. 4/4 tests: skip perl tests if NO_PERL is definedJeff King, Apr 3, 2009
  28. Robin H. JohnsonApr 4, 2009
  29. Jeff KingApr 4, 2009
  30. Jeff KingApr 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.