git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Move launch_editor() from builtin-tag.c to editor.c

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 18, 2008, 01:14 UTC
Message-ID
<alpine.DEB.1.00.0807180313200.2906@eeepc-johanness>
In-Reply-To
<1216341378-15444-1-git-send-email-s-beyer@gmx.net>
Hi,
On Fri, 18 Jul 2008, Stephan Beyer wrote:
> launch_editor() is declared in strbuf.h but defined in builtin-tag.c. 
> This patch moves launch_editor() into a new source file editor.c, but 
> keeps the declaration in strbuf.h.

Sorry, but that has been tried before. Junio pointed out that launch_editor() iss too die()-happy, and that the messages are too bound to the current callers.

You need to at least provide an add-on patch to fix both issues.

Ciao, Dscho

Previous: Stephan BeyerNext: Stephan Beyer
Message 2 of 17 in “Move launch_editor() from builtin-tag.c to editor.c”
  1. Move launch_editor() from builtin-tag.c to editor.cStephan Beyer, Jul 18, 2008
  2. Johannes SchindelinJul 18, 2008
  3. Stephan BeyerJul 18, 2008
  4. editor.c: Libify launch_editor()Stephan Beyer, Jul 18, 2008
  5. Johannes SchindelinJul 18, 2008
  6. editor.c: Libify launch_editor()Stephan Beyer, Jul 18, 2008
  7. Stephan BeyerJul 23, 2008
  8. Stephan BeyerJul 24, 2008
  9. Junio C HamanoJul 25, 2008
  10. Johannes SchindelinJul 25, 2008
  11. Stephan BeyerJul 25, 2008
  12. Johannes SchindelinJul 25, 2008
  13. 1/2 Move launch_editor() from builtin-tag.c to editor.cStephan Beyer, Jul 25, 2008
  14. 2/2 editor.c: Libify launch_editor()Stephan Beyer, Jul 25, 2008
  15. Stephan BeyerJul 25, 2008
  16. Johannes SchindelinJul 26, 2008
  17. Stephan BeyerJul 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.