From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 18 Jul 2008 01:14:42 GMT
Subject: Re: [PATCH] Move launch_editor() from builtin-tag.c to editor.c
Message-ID: <alpine.DEB.1.00.0807180313200.2906@eeepc-johanness>
In-Reply-To: <1216341378-15444-1-git-send-email-s-beyer@gmx.net>

Hi,

On Fri, 18 Jul 2008, Stephan Beyer wrote:

> launch_editor() is declared in strbuf.h but defined in builtin-tag.c. 
> This patch moves launch_editor() into a new source file editor.c, but 
> keeps the declaration in strbuf.h.

Sorry, but that has been tried before.  Junio pointed out that 
launch_editor() iss too die()-happy, and that the messages are too bound 
to the current callers.

You need to at least provide an add-on patch to fix both issues.

Ciao,
Dscho