Re: [PATCH] Move launch_editor() from builtin-tag.c to editor.c

From: Stephan Beyer <s-beyer@gmx.net>
Date: Jul 18, 2008, 01:26 UTC
Message-ID: <20080718012604.GF8421@leksak.fem-net>
In-Reply-To: <alpine.DEB.1.00.0807180313200.2906@eeepc-johanness>

Hi,

Johannes Schindelin wrote:

Show 11 quoted lines

> Hi,
> 
> On Fri, 18 Jul 2008, Stephan Beyer wrote:
> 
> > launch_editor() is declared in strbuf.h but defined in builtin-tag.c. 
> > This patch moves launch_editor() into a new source file editor.c, but 
> > keeps the declaration in strbuf.h.
> 
> Sorry, but that has been tried before.  Junio pointed out that 
> launch_editor() iss too die()-happy, and that the messages are too bound 
> to the current callers.

Ah, a short note: this is not a real "libify" patch. It is more an
"Oh, launch_editor is used for git-commit and git-tag, but it is only
 defined in builtin_tag.c, but declared (as libgit.a member) in strbuf.h,
 so let's move it" patch without further changes.

But of course you and Junio are right.

> You need to at least provide an add-on patch to fix both issues.

Tomorrow, I need sleep first :)

Regards.

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F