Re: [PATCH] editor.c: Libify launch_editor()

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2008, 10:28 UTC
Message-ID: <alpine.DEB.1.00.0807251226500.11976@eeepc-johanness>
In-Reply-To: <7vvdyuuzq2.fsf@gitster.siamese.dyndns.org>

Hi,

On Fri, 25 Jul 2008, Junio C Hamano wrote:

Show 15 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Fri, 18 Jul 2008, Stephan Beyer wrote:
> >
> >> diff --git a/editor.c b/editor.c
> >> index 483b62d..5d7f5f9 100644
> >> --- a/editor.c
> >> +++ b/editor.c
> >> @@ -17,9 +17,8 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e
> > ...
> > Why not "return error()"?
> >
> > Rest looks obviously correct to me!
> 
> This is a patch to an existing file editor.c???

Yes, Stephan sent the two patches unrelatedly, even if they should have been marked "1/2" and "2/2". I hope he does so now.

Ciao, Dscho