Re: [PATCH] editor.c: Libify launch_editor()

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 25, 2008, 08:36 UTC
Message-ID: <7vvdyuuzq2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0807181405510.3932@eeepc-johanness>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 9 quoted lines

> Hi,
>
> On Fri, 18 Jul 2008, Stephan Beyer wrote:
>
>> This patch removes exit()/die() calls and builtin-specific messages from 
>> launch_editor(), so that it can be used as a general libgit.a function 
>> to launch an editor.
>
> Thanks.  Now we have to convince Junio that it is a good idea :-)

Eh, excuse me.

Show 9 quoted lines

>> diff --git a/editor.c b/editor.c
>> index 483b62d..5d7f5f9 100644
>> --- a/editor.c
>> +++ b/editor.c
>> @@ -17,9 +17,8 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e
> ...
> Why not "return error()"?
>
> Rest looks obviously correct to me!

This is a patch to an existing file editor.c???