Re: [PATCH] editor.c: Libify launch_editor()

From: Stephan Beyer <s-beyer@gmx.net>
Date: Jul 23, 2008, 23:09 UTC
Message-ID: <20080723230923.GA12754@leksak.fem-net>
In-Reply-To: <alpine.DEB.1.00.0807181405510.3932@eeepc-johanness>

Hi,

Johannes Schindelin wrote:

Show 5 quoted lines

> > This patch removes exit()/die() calls and builtin-specific messages from 
> > launch_editor(), so that it can be used as a general libgit.a function 
> > to launch an editor.
> 
> Thanks.  Now we have to convince Junio that it is a good idea :-)

Well, I've seen that *a lot* of lib code (15 functions, see below) is in the builtins.

Cleaning that up seems to be good to have a real separation between libgit and builtins, but I guess such a change would not find its way into 1.6.0, would it?

Regards,
  Stephan

PS: I've spontaneously decided to make a list:

defined-in	func-name	 - used in builtin-\1.c

builtin-add.c:
	add_files_to_cache()	 - add, checkout, commit
	interactive_add()	 - add, commit

builtin-archive.c:
	parse_pathspec_arg()	 - archive, uploard-archive

builtin-init-db.c:
	init_db()		 - init-db, clone

builtin-ls-files.c:
	overlay_tree_on_cache()	 - ls-files, commit
	report_path_error()	 - ls-files, checkout, commit

builtin-mailsplit.c:
	read_line_with_nul()	 - mailsplit, mailinfo

builtin-merge-recursive.c:
	write_tree_from_memory() - merge-recursive, checkout

builtin-prune-packed.c:
	prune_packed_objects()	 - prune-packed, prune

builtin-shortlog.c:
	shortlog_add_commit()	 - shortlog, log
	shortlog_init()		 - shortlog, log
	shortlog_output()	 - shortlog, log
	shortlog_init()		 - shortlog, log

builtin-stripspace.c:
	stripspace()		 - stripspace, commit, tag

And launch_editor() that is handled by the patch in this thread.

Then there are functions that are non-static, but not declined in any .h file. A patch that makes them static follows in a separate mail.

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F