Re: [PATCH v2 04/13] Teach rebase interactive the mark command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 22, 2008, 08:52 UTC
Message-ID: <alpine.DEB.1.00.0804220949590.4460@eeepc-johanness>
In-Reply-To: <7vabjm78v2.fsf@gitster.siamese.dyndns.org>

Hi,

On Mon, 21 Apr 2008, Junio C Hamano wrote:

Show 15 quoted lines

> Jörg Sommer <joerg@alea.gnuu.de> writes:
> 
> > @@ -244,6 +252,19 @@ peek_next_command () {
> >  	sed -n "1s/ .*$//p" < "$TODO"
> >  }
> >  
> > +mark_to_ref () {
> > +	case "$1" in
> > +	:[!/]*)
> > +		# :/SOMETHING is a reference for the last commit whose
> > +                # message starts with SOMETHING
> > +		echo "$mark_prefix${1#:}"
> > +		;;
> 
> What was the conclusion of the mark-syntax discussion?

Well, I will probably work on something that is not as intrusive and syntax-changing this week.

> While I know the bang in ":[!negated]" is POSIX, I wonder if everybody's
> shell we care about groks it.

The common way to do that in the git sources is

	switch "$x" in
	/*)
		# do nothing
		;;
	*)
		<bla>
		;;
	esac

and frankly, I do not see a reason to move away from that practice. Especially since consistency in source code is better than inconsistency.

Ciao, Dscho