Re: [PATCH v2 04/13] Teach rebase interactive the mark command

From: Jörg Sommer <joerg@alea.gnuu.de>
Date: Apr 25, 2008, 09:11 UTC
Message-ID: <20080425091117.GA23726@alea.gnuu.de>
In-Reply-To: <7vlk35ydf0.fsf@gitster.siamese.dyndns.org>

Hi Junio,

Junio C Hamano schrieb am Tue 22. Apr, 11:04 (-0700):

Show 13 quoted lines

> Jörg Sommer <joerg@alea.gnuu.de> writes:
> 
> > What do you think about this version:
> >
> > cleanup_before_quit () {
> > 	rm -rf "$DOTEST" &&
> > 	for ref in $(git for-each-ref --format='%(refname)' ${mark_prefix%/})
> > 	do
> > 		git update-ref -d "$ref" "$ref" || return 1
> > 	done
> > }
> 
> Yeah, except you would want to dqquote "${mark_prefix%/}" part.

Oh, yes.

> Also this being a "clean-up" phase, I wonder if we want to stop at the
> first error (e.g. should unremovable "$DOTEST" leave marks behind?

I think it should be the other way: unremovable marks should leave the DOTEST behind. This way a rebase should refuse to start a new session and stumble accross the old marks and it's possible to run git rebase --abort after manually removing the marks.

Bye, Jörg.

-- 
Damit das Mögliche entsteht, muß immer wieder das Unmögliche versucht
werden.                                       (Hermann Hesse)