Re: [PATCH/RFC 06/10] Unify the lenght of $SHORT* and the commits in the TODO list

From: Junio C Hamano <junio@pobox.com>
Date: Apr 12, 2008, 00:00 UTC
Message-ID: <7vej9cndqp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1207785521-27742-7-git-send-email-joerg@alea.gnuu.de>

Jörg Sommer <joerg@alea.gnuu.de> writes:

Show 18 quoted lines

> ---
>  git-rebase--interactive.sh |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> index 1698c3e..060b40f 100755
> --- a/git-rebase--interactive.sh
> +++ b/git-rebase--interactive.sh
> @@ -600,9 +600,9 @@ do
>  			MERGES_OPTION=--no-merges
>  		fi
>  
> -		SHORTUPSTREAM=$(git rev-parse --short $UPSTREAM)
> -		SHORTHEAD=$(git rev-parse --short $HEAD)
> -		SHORTONTO=$(git rev-parse --short $ONTO)
> +		SHORTUPSTREAM=$(git rev-parse --short=7 $UPSTREAM)
> +		SHORTHEAD=$(git rev-parse --short=7 $HEAD)
> +		SHORTONTO=$(git rev-parse --short=7 $ONTO)

Lacking is a better justification as to why this is a good change and 7 is a good number.