Re: [PATCH 10/11] sequencer: use an enum to represent result of picking a commit

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Jul 6, 2026, 11:12 UTC
Message-ID: <akuNmMFST8W2H2Ru@ugly.lan>
In-Reply-To: <e4050ead27f1e01ca72acc849fa16bd67e0d1c4b.1782833268.git.phillip.wood@dunelm.org.uk>

On Tue, Jun 30, 2026 at 04:29:00PM +0100, Phillip Wood wrote:

Show 5 quoted lines

>Rather than using an integer where -1 is an error, 0 is success and
>1 means there were conflicts use an enum. This is clearer and lets
>us add a separate return value for commits that are dropped because
>they become empty in the next commit.
>

have you attempted widening the scope of the enum? the three conversions between the new enum and existing int return values irk me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.