Re: [PATCH 09/11] sequencer: return early from pick_one_commit() on success
- From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
- Date
- Jul 6, 2026, 11:08 UTC
- Message-ID
- <akuMrp3W1bG6d43D@ugly.lan>
- In-Reply-To
- <2541a4d6e3d41272c31c8fafdf4eadcbc71b63f3.1782833268.git.phillip.wood@dunelm.org.uk>
On Tue, Jun 30, 2026 at 04:28:59PM +0100, Phillip Wood wrote:
>The only block that does not return early is the one guarded by >"!res". Move the return into that block to make it clear that after >recording the commit as rewritten all we do is return from the function. >
i think it would be much more logical to just squash that into the parent commit.