Re: [PATCH 10/11] sequencer: use an enum to represent result of picking a commit

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jul 6, 2026, 13:39 UTC
Message-ID: <9771702d-49c4-496a-a77f-22c244acc443@gmail.com>
In-Reply-To: <akuNmMFST8W2H2Ru@ugly.lan>

On 06/07/2026 12:12, Oswald Buddenhagen wrote:

Show 8 quoted lines

> On Tue, Jun 30, 2026 at 04:29:00PM +0100, Phillip Wood wrote:
>> Rather than using an integer where -1 is an error, 0 is success and
>> 1 means there were conflicts use an enum. This is clearer and lets
>> us add a separate return value for commits that are dropped because
>> they become empty in the next commit.
>>
> have you attempted widening the scope of the enum? the three conversions 
> between the new enum and existing int return values irk me.

I know what you mean, but how wide should be go? Using the enum just one level up the call chain means converting a whole load of functions which creates a lot of churn that someone needs to review. I decided to keep the enum limited to this scope for now to avoid that.

Thanks

Phillip