Re: [PATCH v5 5/9] ref: add basic symref content check for files backend
- From
shejialuo <shejialuo@gmail.com>
- Date
- Oct 8, 2024, 12:18 UTC
- Message-ID
- <ZwUjCnxPw0NObj5d@ArchLinux>
- In-Reply-To
- <CAOLa=ZQGaLJTJ-bcSYD1mcsgCD8ayHYzXatmK2iyz4gDodvvKA@mail.gmail.com>
On Tue, Oct 08, 2024 at 12:58:16AM -0700, Karthik Nayak wrote:
Show 16 quoted lines
> shejialuo <shejialuo@gmail.com> writes: > > > We have code that checks regular ref contents, but we do not yet check > > the contents of symbolic refs. By using "parse_loose_ref_content" for > > symbolic refs, we will get the information of the "referent". > > > > We do not need to check the "referent" by opening the file. This is > > because if "referent" exists in the file system, we will eventually > > check its correctness by inspecting every file in the "refs" directory. > > If the "referent" does not exist in the filesystem, this is OK as it is > > seen as the dangling symref. > > > > So we just need to check the "referent" string content. A regular could > > seems like we're missing the noun here, a regular what? >
It should be "a regular ref". I copied the original commit message and may carelessly type "daw" in vim to delete the "ref". Thanks.