Re: [PATCH v5 9/9] ref: add symlink ref content check for files backend

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 7, 2024, 06:58 UTC
Message-ID: <ZwOGqpeYiKITgsoV@pks.im>
In-Reply-To: <Zvj_EELQdMsN7j2w@ArchLinux>

On Sun, Sep 29, 2024 at 03:17:36PM +0800, shejialuo wrote:

Show 5 quoted lines

> We have already introduced "files_fsck_symref_target". We should reuse
> this function to handle the symrefs which use legacy symbolic links. We
> should not check the trailing garbage for symbolic refs. Add a new
> parameter "symbolic_link" to disable some checks which should only be
> executed for textual symrefs.

You're getting into implementation details before noting what the actual problem is. So I'd recommend first describing the problem at a higher level, and then note that we can reuse parts of preexisting infra to address the issue.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.