Re: [PATCH v5 3/9] ref: port git-fsck(1) regular refs check for files backend

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 7, 2024, 09:18 UTC
Message-ID: <ZwOnYAx_h9uGzPst@pks.im>
In-Reply-To: <ZwOfBCSTO4Qvtos3@ArchLinux>

On Mon, Oct 07, 2024 at 04:42:44PM +0800, shejialuo wrote:

Show 15 quoted lines

> On Mon, Oct 07, 2024 at 08:58:34AM +0200, Patrick Steinhardt wrote:
> > On Sun, Sep 29, 2024 at 03:15:46PM +0800, shejialuo wrote:
> > > "git-fsck(1)" will report an error when the ref content is invalid.
> > > Following this, add a similar check to "git refs verify". Then add a new
> > > fsck error message "badRefContent(ERROR)" to represent that a ref has an
> > > invalid content.
> > 
> > It would help readers to know where the code is that you're porting over
> > to `git refs verify` so that one can double check that the port is done
> > faithfully to the original.
> > 
> 
> I am a little confused here. There are too many codes in "git-fsck(1)"
> to check the ref consistency. How could I accurately express this info
> in the commit message?

Well, you say you ported over a specific consistency check from git-fsck(1) to `git refs verify` in the commit message. So I assume that it should match a specific check in git-fsck(1), shouldn't it?

Patrick