Re: [PATCH v5 8/9] t0602: add ref content checks for worktrees

From: shejialuo <shejialuo@gmail.com>
Date: Oct 7, 2024, 08:45 UTC
Message-ID: <ZwOftTrlYZh9Oz63@ArchLinux>
In-Reply-To: <ZwOGoxXmn_J6pgh1@pks.im>

On Mon, Oct 07, 2024 at 08:58:43AM +0200, Patrick Steinhardt wrote:

Show 10 quoted lines

> On Sun, Sep 29, 2024 at 03:17:18PM +0800, shejialuo wrote:
> > We have already added content tests, but we don't have tests when there
> > are worktrees in the repository. Add a new test to test all the
> > functionalities we have added for worktrees.
> 
> I'd squash this commit into the one where you introduced checks for
> worktrees. Or if this exercises errors that you have added in subsequent
> commits I'd squash it into the respective commit that introduces those
> checks.
>

Yes, make sense. I will improve this in the next version.

> Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.