Re: [PATCH v3 2/4] Makefile: add ability to append to CFLAGS and LDFLAGS

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 10, 2024, 07:01 UTC
Message-ID: <ZmaksqGEpLcMCjrn@tanuki>
In-Reply-To: <xmqq4ja3cl87.fsf@gitster.g>

On Sat, Jun 08, 2024 at 12:01:28PM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Another way to do this is just:
> >
> > diff --git a/Makefile b/Makefile
> > index 2f5f16847a..9cd3b252ff 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1446,8 +1446,8 @@ ALL_COMMANDS_TO_INSTALL += git-upload-archive$(X)
> >  ALL_COMMANDS_TO_INSTALL += git-upload-pack$(X)
> >  endif
> >  
> > -ALL_CFLAGS = $(DEVELOPER_CFLAGS) $(CPPFLAGS) $(CFLAGS)
> > -ALL_LDFLAGS = $(LDFLAGS)
> > +ALL_CFLAGS = $(DEVELOPER_CFLAGS) $(CPPFLAGS) $(CFLAGS) $(CFLAGS_APPEND)
> > +ALL_LDFLAGS = $(LDFLAGS) $(LDFLAGS_APPEND)
> 
> Much nicer.

Agreed, this is much nicer. Will adapt, thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.